-
Notifications
You must be signed in to change notification settings - Fork 937
Allow to override build user and host #5653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
1af48af to
ce117aa
Compare
|
ok to test |
|
Thanks for bringing this to our attention again; I admit it kinda fell off our radar. 😦 Are you looking for both this PR and #3779 to be merged? (it looks like that one kinda fell off the radar, too...) Also, per the discussion in #3759, are you interested in an output line in |
|
I'd say, this change perfectly complements #3779 We could use export HOSTNAME=reproducible-SUSE-rpm-buildwhich should show up in ompi_info as well |
|
I'm good with this PR. Mind if I add a commit to it with a short README blurb about setting |
|
@bmwiedemann Ping. |
|
oops, missed the other comment. Yes, please add blurb with that URL. |
to remove useless code duplication Signed-off-by: Bernhard M. Wiedemann <[email protected]>
using the standard $USER and $HOSTNAME environment variables to make reproducible builds possible. See https://reproducible-builds.org/ for why this is good. This helps improve issue open-mpi#3759 Signed-off-by: Bernhard M. Wiedemann <[email protected]>
Signed-off-by: Jeff Squyres <[email protected]>
|
@bmwiedemann I rebased to the current HEAD (since this commit was super old) and added a 3rd commit with a README blurb. Look ok? @ggouaillardet You might want to expand on this README blurb in #3779...? |
|
LGTM |
|
Can you merge this PR, please? |
|
Thanks for your patience -- merged! |
Allow to override build user and host, using the standard $USER and $HOSTNAME environment variables to make reproducible builds possible.
See https://reproducible-builds.org/ for why this is good.
This helps improve issue #3759