OSHMEM/ATOMICS: added C implementation of and/or/xor ops #5392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The IBM CI (GNU Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/00e377d6d3e9eadd0335fafa54332edb |
|
The IBM CI (XL Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/3b271624c46b11d23941c8e99caf072e |
|
The IBM CI (PGI Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/9e930eecace3705c840ee5049bdd4dfe |
- added implementation and/or/xor operations for post and fetch-op notations - implemented basic and UCX transports, mxm added NON-IMPLEMENTED wrapper - updated C interfaces only (fortran will be added later) - existing API is not updated to spec v1.4 Signed-off-by: Sergey Oblomov <[email protected]>
hoopoepg
force-pushed
the
topic/bitwise-atomics-c
branch
from
f2c5f75 to
64212a9
Compare
Contributor
Author
|
bot:retest |
Contributor
Author
|
@brminich could you review? |
brminich
reviewed
Jul 10, 2018
oshmem/mca/atomic/atomic.h
Outdated
| pe)); \ | ||
| RUNTIME_CHECK_RC(rc); \ | ||
| \ | ||
| return ; \ |
Member
There was a problem hiding this comment.
minor: extra whitespace after return
oshmem/shmem/c/shmem_and.c
Outdated
|
|
||
| /* | ||
| * These routines perform an atomic 'and' operation. | ||
| * The atomic 'and' routines cwoperates 'and' value to the data at address target on PE pe. |
oshmem/shmem/c/shmem_for.c
Outdated
| * These routines perform an atomic fetch-and-or operation. | ||
| * The fetch and or routines retrieve the value at address target on PE pe, and update | ||
| * target with the result of 'or' operation value to the retrieved value. The operation | ||
| * must be completed * without the possibility of another process updating target between |
oshmem/shmem/c/shmem_fxor.c
Outdated
| * These routines perform an atomic fetch-and-xor operation. | ||
| * The fetch and xor routines retrieve the value at address target on PE pe, and update | ||
| * target with the result of 'xor' operation value to the retrieved value. The operation | ||
| * must be completed * without the possibility of another process updating target between |
oshmem/shmem/c/shmem_or.c
Outdated
|
|
||
| /* | ||
| * These routines perform an atomic 'or' operation. | ||
| * The atomic 'or' routines cwoperates 'or' value to the data at address target on PE pe. |
oshmem/shmem/c/shmem_xor.c
Outdated
|
|
||
| /* | ||
| * These routines perform an atomic 'xor' operation. | ||
| * The atomic 'xor' routines cwoperates 'xor' value to the data at address target on PE pe. |
brminich
approved these changes
Jul 10, 2018
Signed-off-by: Sergey Oblomov <[email protected]>
Contributor
Author
|
bot:retest |
2 similar comments
Contributor
Author
|
bot:retest |
Contributor
Author
|
bot:retest |
Contributor
Author
|
@yosefe could you look? |
Contributor
Author
|
@brminich all comments are addressed |
brminich
approved these changes
Jul 10, 2018
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch-op notations
NON-IMPLEMENTED wrapper
Signed-off-by: Sergey Oblomov [email protected]