v5.10.x: Fortran REAL16: improve detection and wiring across OMPI/OPAL#13714
Open
bosilca wants to merge 2 commits intoopen-mpi:v5.0.xfrom
Open
v5.10.x: Fortran REAL16: improve detection and wiring across OMPI/OPAL#13714bosilca wants to merge 2 commits intoopen-mpi:v5.0.xfrom
bosilca wants to merge 2 commits intoopen-mpi:v5.0.xfrom
Conversation
bosilca
force-pushed
the
v5.x/topic/better_support_for_fortran_real16
branch
from
415a24b to
ea7829d
Compare
bosilca
changed the title
bosilca
changed the title
for count args. This helps with the big count effort. Related to open-mpi#12226 Related to open-mpi#13152 Signed-off-by: Howard Pritchard <howardp@lanl.gov> (cherry picked from commit 2fef284)
Probe REAL*16 against _Float128 first, then __float128, and finally _Quad (Intel) to find a C type with matching bit representation. Ensure OPAL’s FLOAT12/FLOAT16 constructors are always available and map OMPI/MPI REAL16 based on architecture/language specifics. Wire FLOAT128 types through copy/pack/unpack paths and hook REAL16 into the base MPI_Op table. This enables software-only reductions for REAL16 for as long as the Fortran type has a C equivalent. When an OPAL type description is decided at build time (such as float12 and float16), create an OPAL-level #define with their selected size. This allow the rest of the code to simply use this size instead of trying to figure out what is the real size of the type. Signed-off-by: George Bosilca <gbosilca@nvidia.com> (cherry picked from commit 941af5e)
bosilca
force-pushed
the
v5.x/topic/better_support_for_fortran_real16
branch
from
ea7829d to
55a05f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probe REAL*16 against _Float128 first, then __float128, and finally _Quad (Intel) to find a C type with matching bit representation. Ensure OPAL’s FLOAT12/FLOAT16 constructors are always available and map OMPI/MPI REAL16 based on architecture/language specifics.
Wire FLOAT128 types through copy/pack/unpack paths and hook REAL16 into the base MPI_Op table. This enables software-only reductions for REAL16 for as long as the Fortran type has a C equivalent.
When an OPAL type description is decided at build time (such as float12 and float16), create an OPAL-level #define with their selected size. This allow the rest of the code to simply use this size instead of trying to figure out what is the real size of the type.
#13612 backport for the 5.x (including additional necessary commits)
(cherry picked from commit 941af5e)