accelerator/cuda: Dereference pointer to stream #12635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuMemcpyAsync and cuStreamSynchronize take a CUstream, not a pointer to CUstream. Signed-off-by: Joseph Schuchart <[email protected]>
Contributor
|
@devreal Thanks. Curious if this was caught by the compiler or something else? Meanwhile let me run our CI to double check. |
Contributor
Author
|
That was a compiler warning I saw when compiling against CUDA. Not sure how that doesn't crash, maybe we never hit this code path |
bosilca
changed the title
Contributor
Author
|
@janjust looks like the NVIDIA CI ran out of disk space |
Member
|
It crashes all over the place. I was just starting to investigate, but it looks legit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuMemcpyAsync and cuStreamSynchronize take a CUstream, not a pointer to CUstream.
Artifact of #12617