btlsmcuda: fix problem with makefile #12083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@hppritcha I think you need to make same change to the rcache/gpusm and rcache/rgpusm components as well, they also have cuda calls in the source code without the corresponding setting of LDFLAGS |
Member
Author
|
thanks for the heads up @edgargabriel |
when libcuda.so is in a non-standard location. also fix rcache/gpusm and rcache/rgpsum Similar fix to that in open-mpi#12065 Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
force-pushed
the
btlsmcuda_makefile_fix
branch
from
2b734a9 to
2767278
Compare
edgargabriel
approved these changes
Nov 16, 2023
wenduwan
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when libcuda.so is in a non-standard location.
Similar fix to that in #12065