Fix missing lock release in ompi_coll_adapt_ibcast_generic: Coverity CID 1498641 #11200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity CID 1498641 Signed-off-by: David Wootton <[email protected]>
bosilca
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity static analysis reports a missing lock release in ompi_coll_adapt_ibcast_generic.
The lock is initially obtained before entering the loop at line 477. The lock is released and then obtained again at
the bottom of each loop iteration.
If the call at line 499 fails, the lock is not released an there can be an application hang.
Since the lock needs to be released both for the error return and normal loop iteration, I moved
the OMPI_THREAD_UNLOCK macro before the error return check.
Signed-off-by: David Wootton [email protected]