Skip to content

common/ucx: call opal_progress when waiting for pmix_fence #11143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsquyres merged 1 commit into from
Dec 5, 2022
Merged

common/ucx: call opal_progress when waiting for pmix_fence #11143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions opal/mca/common/ucx/common_ucx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,8 +416,10 @@ OPAL_DECLSPEC int opal_common_ucx_mca_pmix_fence(ucp_worker_h worker)
return ret;
}

while (!fenced) {
ucp_worker_progress(worker);
MCA_COMMON_UCX_PROGRESS_LOOP(worker) {
if(fenced) {
break;
}
Comment on lines +419 to +422
Copy link
Contributor

@yosefe yosefe Dec 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems the difference if whether progress is called if fenced==true before line 419?
but if fence is already completed why still need to call progress?

Copy link
Member

@brminich brminich Dec 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the fix here is that MCA_COMMON_UCX_PROGRESS_LOOP also invokes opal_progress which progresses hcoll

}

return ret;
Expand Down