v5.0.x: mca: update "show_load_errors" behavior #10830
Merged
+369
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the MCA parameter "opal_mca_base_component_show_load_errors" to be a flexible mechanism to specify when (and when not) to emit warnings about errors when trying to load DSO components.
Convert the existing MCA parameter opal_mca_base_component_show_load_errors from a boolean to a string. It will still accept all prior valid boolean values, but it will also accept comma-delimited list of "framework[/component]" tokens. If the MCA base encounters an error when loading a DSO, opal_mca_base_component_show_load_errors is checked to see if a warning should be emitted.
framework/component), then only the specified component in the specified framework will match.NOTE: The equivalence of "all" with boolean true values, and
"none" with boolean false values is only intended as a
backwards compatibility mechanism, since prior to this
commit, opal_mca_base_component_show_load_errors was a
boolean value. It is not intended as a general mechanism
that should be copied to all other include/exclude-type MCA
params.
Remove the configure option --enable-show-load-errors-by-default, replace it with --with-show-load-errors[=value]. The value specified will become the default value of the opal_mca_base_component_show_load_errors MCA variable (it defaults to "all").
The CLI option name change is intentional. The previous MCA parameter only accepted boolean values; the new CLI name reflects that it can accept more than just boolean values.
The rationale for this commit is to allow packagers more granular control over whether to warn about component DSO load failures or not.
The canonical example of where this is useful is accelerator libraries: since accelerators are expensive, they may only be available on a subset of nodes in a given HPC environment. Consequently, the accelerator's support libraries may only be loaded on the nodes that actually have accelerators physically present. In such an environment, an administrator or packager may wish to configure Open MPI:
For example:
Signed-off-by: Jeff Squyres [email protected]
(cherry picked from commit 20bbf27)
This is the v5.0.x PR corresponding to the main PR #10763