Skip to content

Conversation

@jsquyres
Copy link
Member

@jsquyres jsquyres commented Sep 7, 2022

  • Removed a bunch of redundant text and replaced it with links to elsewhere in the docs.
  • Added developer-level rules of thumb for levels 1-9 of MCA params.
  • Added code style documentation; consolidated this and "source code tree layout" into a single source-code.rst file.

Signed-off-by: Jeff Squyres [email protected]

@jsquyres
Copy link
Member Author

jsquyres commented Sep 7, 2022

bot:aws:recheck

Copy link
Member

@jjhursey jjhursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor-ish notes, but otherwise an improvement. Thanks!

* Removed a bunch of redundant text and replaced it with links to
  elsewhere in the docs.
* Added developer-level rules of thumb for levels 1-9 of MCA params.
* Added code style documentation; consolidated this and "source code
  tree layout" into a single source-code.rst file.

Signed-off-by: Jeff Squyres <[email protected]>
Note on the front page that the v5.0.0 docs are on the public web
site, in the tarball, and installed locally.

Signed-off-by: Jeff Squyres <[email protected]>
@jsquyres jsquyres force-pushed the pr/docs/developer-updates branch from 2bc253a to f33d3d4 Compare September 7, 2022 16:16
@jsquyres
Copy link
Member Author

jsquyres commented Sep 7, 2022

@jjhursey I made all the suggested changes.

I also added another commit that updates the front page to show all 3 locations of the v5.0.0 docs (public web site, in the tarball, and installed). Once merged, this 2nd commit should be pulled to the v4.0.x and v4.1.x branches. See https://ompi--10771.org.readthedocs.build/en/10771/

@jsquyres jsquyres merged commit 50856c2 into open-mpi:main Sep 7, 2022
@jsquyres jsquyres deleted the pr/docs/developer-updates branch September 7, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants