v4.1.x: First commit of libevent 2.1.12 #10602
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace libevent 2.0.22 with 2.1.12 to address some CVEs. The CVEs in question were in code that Open MPI did not use, and were therefore harmless. However, in order to not have to continually explain this to end users, we'll just upgrade the embedded libevent to a version that does not contain the CVEs at all. Signed-off-by: Jeff Squyres <[email protected]>
Member
Author
|
Hey @bwbarrett I'm unable to replicate the linker error that is showing up on the OMPI/Jenkins CI link fails. I've tried on MacOS, RHEL 6 and 7, and Ubuntu 20 (which is what the CI is using). Any idea what is happening on that failure? |
Member
Author
|
After much discussion and back-n-forth, this PR seems to be too much of a pain. Instead, we're going to merge the upstream patches in #10565. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this PR in case #10565 is not sufficient: it upgrades the libevent on the v4.1.x branch to libevent 2.1.12. I'm opening this PR to see how well it does against CI testing.
There's at least a little more work that would need to be done on this PR if we want to merge it:
make install-exec-hookgives warnings about common symbols in libevent.ofiles.opal_rename.hfile needs to be extended to include the new public symbols in libevent 2.1.12.bot:notacherrypick
Refs: #10542, #10565, #10583
Replace libevent 2.0.22 with 2.1.12 to address some CVEs. The CVEs in
question were in code that Open MPI did not use, and were therefore
harmless. However, in order to not have to continually explain this
to end users, we'll just upgrade the embedded libevent to a version
that does not contain the CVEs at all.
Signed-off-by: Jeff Squyres [email protected]