Skip to content

fbtl/posix: fix length calculation for data sieving #10578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwbarrett merged 1 commit into from
Jul 18, 2022
Merged

fbtl/posix: fix length calculation for data sieving #10578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ompi/mca/fbtl/posix/fbtl_posix_preadv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@ ssize_t mca_fbtl_posix_preadv_datasieving (ompio_file_t *fh)
}

size_t sstart = (size_t)fh->f_io_array[startindex].offset;
size_t slen=0;
size_t slen=0, maxlen=0;
int maxindex = startindex;

for ( j = startindex; j < fh->f_num_of_io_entries; j++ ) {
endindex = j;
Expand All @@ -130,15 +131,19 @@ ssize_t mca_fbtl_posix_preadv_datasieving (ompio_file_t *fh)
endindex = j-1;
break;
}
if (slen > maxlen) {
maxlen = slen;
maxindex = endindex;
}
}
// Need to increment the value of endindex
// by one for the loop syntax to work correctly.
endindex++;

start = (size_t)fh->f_io_array[startindex].offset;
end = (size_t)fh->f_io_array[endindex-1].offset + fh->f_io_array[endindex-1].length;
end = (size_t)fh->f_io_array[maxindex].offset + fh->f_io_array[maxindex].length;
len = end - start;

if ( len > bufsize ) {
if ( NULL != temp_buf ) {
free ( temp_buf);
Expand Down