set instance field when creating new group objects #10555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
bot:ibm:retest |
Member
Author
|
@awlauria could you review this when you get a chance? |
awlauria
reviewed
Aug 2, 2022
| OMPI_GROUP_SET_DENSE(new_group); | ||
|
|
||
| if (NULL != orig_group) { | ||
| new_group->grp_instance = orig_group->grp_instance; |
Contributor
There was a problem hiding this comment.
I don't recall if OBJ_NEW will zero out the struct - should this be initialized to NULL if not set here?
awlauria
approved these changes
Aug 2, 2022
Contributor
awlauria
left a comment
awlauria
left a comment
There was a problem hiding this comment.
Just one comment - would be good to null that pointer out.
related to open-mpi#10524 and open-mpi#10429 Also related to the isolation concept for sessions (instances in open mpi internal parlance). See section 11.3 of the MPI 4.0 standard Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
force-pushed
the
fix_issue_10524
branch
from
6d1347a to
55cf3a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #10524 and #10429
Also related to the isolation concept for sessions (instances in open mpi internal parlance).
See section 11.3 of the MPI 4.0 standard
Signed-off-by: Howard Pritchard [email protected]