Start fixes: parameter check and return code [v4.1.x] #10552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
approved these changes
Jul 11, 2022
Member
|
@devreal Per #10574 (comment), should we hold off merging this PR? |
Contributor
Author
|
Let's hold off on it and see where we go with it. |
Member
|
Marking a draft until we resolve #10574, so that we don't accidently merge. Other than that issue, I'm ok with this from a RM point of view. |
Contributor
|
I pushed the fix to this branch, should be good to go. |
Contributor
Contributor
|
Converting this back to a draft until the above is resolved. |
Signed-off-by: Joseph Schuchart <[email protected]> (cherry picked from commit 94f9806)
devreal
force-pushed
the
mpi-start-part-inactive-v4.1.x
branch
from
4379b31 to
31f7f77
Compare
Contributor
Author
|
I removed the return value check so it's only the check for inactive requests left in here. |
jsquyres
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two two glitches in MPI_Start:
Check return value of request start function to prevent error codes from leaking.Partial backport of #10543 to v4.1.x (partitioned communication was never backported to v4.1.x)