Skip to content

Start[all] fixes: parameter check and return code #10543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bosilca merged 3 commits into from
Jul 7, 2022
Merged

Start[all] fixes: parameter check and return code #10543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
926af42
Startall: add OMPI_REQUEST_PART to param check
devreal Jul 1, 2022
94f9806
Start: check for OMPI_REQUEST_INACTIVE in param check
devreal Jul 1, 2022
0c89805
Start: check return value of request start function
devreal Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ompi/mpi/c/start.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,14 @@ int MPI_Start(MPI_Request *request)
case OMPI_REQUEST_PML:
case OMPI_REQUEST_COLL:
case OMPI_REQUEST_PART:
if ( MPI_PARAM_CHECK && !(*request)->req_persistent) {
if ( MPI_PARAM_CHECK && !((*request)->req_persistent &&
OMPI_REQUEST_INACTIVE == (*request)->req_state)) {
return OMPI_ERRHANDLER_NOHANDLE_INVOKE(MPI_ERR_REQUEST, FUNC_NAME);
}

ret = (*request)->req_start(1, request);

return ret;
return OMPI_ERRHANDLER_NOHANDLE_INVOKE(ret, FUNC_NAME);

case OMPI_REQUEST_NOOP:
/**
Expand Down
1 change: 1 addition & 0 deletions ompi/mpi/c/startall.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ int MPI_Startall(int count, MPI_Request requests[])
! requests[i]->req_persistent ||
(OMPI_REQUEST_PML != requests[i]->req_type &&
OMPI_REQUEST_COLL != requests[i]->req_type &&
OMPI_REQUEST_PART != requests[i]->req_type &&
OMPI_REQUEST_NOOP != requests[i]->req_type)) {
rc = MPI_ERR_REQUEST;
break;
Expand Down