OSC UCX: Fix the flush issue in dynamic win accumulate #10540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamzi Bayatpour <[email protected]> Co-authored-by: Tomislav Janjusic <[email protected]>
devreal
approved these changes
Jun 30, 2022
Contributor
devreal
left a comment
devreal
left a comment
There was a problem hiding this comment.
The changes here are important. However, blocking for operations to complete inside a nonblocking operation is not desirable. We should change this to starting the GET operations, returning right away, and then performing the accumulate and PUT inside the completion callback. That way we don't waste time waiting for transfers.
Contributor
Author
|
@devreal Thanks for the note. I agree we should not do blocking Get inside Accumulate. Once we are done with stabilizing the code, we are planning to re-design the Accumulate. With the last fix, we have around a 90% pass rate for RMA mpich tests. So we are almost there. |
Contributor
|
bot:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSC UCX: Fix the flush issue in dynamic win accumulate
Signed-off-by: Mamzi Bayatpour [email protected]
Co-authored-by: Tomislav Janjusic [email protected]