coll/ucc: add support for dt float128 float32(64,128)_complex #10500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Member
|
ok to test |
jsquyres
previously requested changes
Jun 22, 2022
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
@samnordmann Please add a signed-off-by line in your commit message to indicate that you agree to Open MPI's Contributor's Declaration: https://github.com/open-mpi/ompi/blob/main/.github/CONTRIBUTING.md#contributors-declaration
Signed-off-by: snordmann <[email protected]>
samnordmann
force-pushed
the
ucc_dt_patch
branch
from
92fe789 to
8b99a15
Compare
jsquyres
dismissed
their stale review
Commit is now signed off properly; thanks.
vspetrov
approved these changes
Jun 23, 2022
janjust
approved these changes
Jun 23, 2022
Contributor
|
@samnordmann please open up the v5.0.x PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for new datatypes in ucc. (openucx/ucc@8afd34a)
New datatypes: float128, float32_complex, float64_complex, float128_complex.