Properly initialize group pointer passed to ompi_group_from_pset #10306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `group` pointer passed from `ompi_comm_init` is checked for equality with MPI_GROUP_NULL in `ompi_group_from_pset` but is never initialized. Valgrind complains about a jump based on uninitialized values. Stack values are never default initialized so we have to explicitly initialize it to `NULL`. Signed-off-by: Joseph Schuchart <[email protected]>
bosilca
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
grouppointer passed fromompi_comm_initis checked for equality withMPI_GROUP_NULLinompi_group_from_psetbut is never initialized. Valgrind complains about a jump based on uninitialized values. Stack values are never default initialized so we have to explicitly initialize it toNULL.Signed-off-by: Joseph Schuchart [email protected]