Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix CI error due to np.int and legacy builder.py #389

Merged
merged 5 commits into from
Dec 19, 2022
Merged

[Fix] Fix CI error due to np.int and legacy builder.py #389

merged 5 commits into from
Dec 19, 2022

Conversation

RangeKing
Copy link
Collaborator

@RangeKing RangeKing commented Dec 19, 2022 •
edited
Loading

Motivation

Fix CI error due to np.int and legacy builder.py, open-mmlab/mmdetection#9479

Modification

  1. Replace all np.int with np.int64.
  2. Replace all build_detector with MODELS.build.
  3. Using the main branch of mmengine instead of the tag version in CI.

PeterH0323
PeterH0323 approved these changes Dec 19, 2022
View reviewed changes
Copy link
Collaborator

@PeterH0323 PeterH0323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeterH0323
Copy link
Collaborator

中英文档 yolov5_description.md 还有一些，也请一并修改

@RangeKing RangeKing changed the title [Fix] Fix CI error due to np.int [Fix] Fix CI error due to np.int and legacy builder.py Dec 19, 2022
hhaAndroid
hhaAndroid reviewed Dec 19, 2022
View reviewed changes
mmyolo/utils/boxam_utils.py Outdated Show resolved Hide resolved
tests/test_models/test_detectors/test_yolo_detector.py Outdated Show resolved Hide resolved
tests/test_models/test_detectors/test_yolo_detector.py Outdated Show resolved Hide resolved
@hhaAndroid hhaAndroid merged commit 051d30a into open-mmlab:dev Dec 19, 2022
@RangeKing RangeKing deleted the fix_ci_error branch December 19, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterH0323 PeterH0323 PeterH0323 approved these changes

@hhaAndroid hhaAndroid hhaAndroid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RangeKing @PeterH0323 @hhaAndroid