Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Support Webcam inference in topdown/bottomup demo. #2244

Merged
merged 5 commits into from
Apr 17, 2023

Conversation

Tau-J
Copy link
Collaborator

@Tau-J Tau-J commented Apr 17, 2023

Motivation

  • Support Webcam inference in topdown/bottomup demo.
  • Support FastVisualizer to conduct efficient demo inference.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@Tau-J Tau-J requested a review from Ben-Louis April 17, 2023 05:50
@Tau-J Tau-J force-pushed the tau/enhance_demo branch from 3cd7b9c to 0f02277 Compare April 17, 2023 06:54
@Ben-Louis
Copy link
Collaborator

Do you think it is necessary to ensure that the interfaces of FastVisualizer remain consistent with those of PoseLocalVisualizer, similar to the visualizers in other OpenMMLab repos?

@Tau-J
Copy link
Collaborator Author

Tau-J commented Apr 17, 2023

Do you think it is necessary to ensure that the interfaces of FastVisualizer remain consistent with those of PoseLocalVisualizer, similar to the visualizers in other OpenMMLab repos?

That's necessary. But how about leaving this kind of stuff as the community assignment?

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (896e9d5) 82.25% compared to head (49763af) 82.29%.

❗ Current head 49763af differs from pull request most recent head 6227ab2. Consider uploading reports for the commit 6227ab2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2244      +/-   ##
===========================================
+ Coverage    82.25%   82.29%   +0.03%     
===========================================
  Files          228      230       +2     
  Lines        13387    13552     +165     
  Branches      2268     2301      +33     
===========================================
+ Hits         11011    11152     +141     
- Misses        1862     1871       +9     
- Partials       514      529      +15     
Flag Coverage Δ
unittests 82.29% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ben-Louis
Copy link
Collaborator

That's necessary. But how about leaving this kind of stuff as the community assignment?

Sure, no problem

demo/bottomup_demo.py Outdated Show resolved Hide resolved
@Tau-J Tau-J merged commit 3ec2e7c into open-mmlab:dev-1.x Apr 17, 2023
@Tau-J Tau-J deleted the tau/enhance_demo branch April 17, 2023 08:11
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants