Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix accepting an unexpected argument local-rank in PyTorch 2.0 #2125

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

LareinaM
Copy link
Collaborator

Motivation

Fix the problem regarding local-rank in PyTorch 2.0

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.87 🎉

Comparison is base (3af7fed) 81.46% compared to head (a30d383) 82.33%.

❗ Current head a30d383 differs from pull request most recent head 4dd0c33. Consider uploading reports for the commit 4dd0c33 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2125      +/-   ##
===========================================
+ Coverage    81.46%   82.33%   +0.87%     
===========================================
  Files          227      227              
  Lines        13513    13340     -173     
  Branches      2306     2261      -45     
===========================================
- Hits         11008    10984      -24     
+ Misses        1987     1842     -145     
+ Partials       518      514       -4     
Flag Coverage Δ
unittests 82.33% <ø> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tau-J Tau-J merged commit 8795523 into open-mmlab:dev-1.x Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants