-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename panoptic seg related and Realse instance seg related for Mask2Former #8032
Conversation
c937e94
to
c864cfd
Compare
Codecov Report
@@ Coverage Diff @@
## dev #8032 +/- ##
==========================================
+ Coverage 64.51% 64.56% +0.05%
==========================================
Files 360 359 -1
Lines 29233 29155 -78
Branches 4954 4938 -16
==========================================
- Hits 18859 18825 -34
+ Misses 9370 9329 -41
+ Partials 1004 1001 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
b66f487
to
1d74def
Compare
* rename * add configs for mask2former instance segmentation * rename panoptic seg related and add instance seg related * update readme * fix bug in gather_model.py * fix link * fix link * update readme * update config * update readme * update readme
* rename * add configs for mask2former instance segmentation * rename panoptic seg related and add instance seg related * update readme * fix bug in gather_model.py * fix link * fix link * update readme * update config * update readme * update readme
* rename * add configs for mask2former instance segmentation * rename panoptic seg related and add instance seg related * update readme * fix bug in gather_model.py * fix link * fix link * update readme * update config * update readme * update readme
* rename * add configs for mask2former instance segmentation * rename panoptic seg related and add instance seg related * update readme * fix bug in gather_model.py * fix link * fix link * update readme * update config * update readme * update readme
Hey, thanks for all of your work for Mask2Former. Recently, i am learning the code of MPFomer, which is modified from Mask2Former, and the only differences between MPFormer and Mask2Fomer are in mask2former_transformer_decoder.py and criterion.py which construct the MP training queries and loss function. I would like to convert the code from Detectron2 to MMDetection, but i am confused that I can't find the part(mask2former_transformer_decoder.py) they modified in MMDetection, it makes me hard to rewrite the code in MMDetection. So i would like to ask you guys to give me some advices to implement thisk work your time permits. |
@Levine66, Code related to transformer decoder is in https://github.com/open-mmlab/mmdetection/blob/2.x/mmdet/models/utils/transformer.py. |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Modification
mask2former_xxx_coco.py
->mask2former_xxx_coco-panoptic.py
.mask2former_xxx_coco.py
is for instance segmentation, whilemask2former_xxx_coco-panoptic.py
for panoptic segmentation.BC-breaking (Optional)
Rename configs for panoptic segmentation:
mask2former_xxx_coco.py
->mask2former_xxx_coco-panoptic.py
.mask2former_xxx_coco.py
is for instance segmentation, whilemask2former_xxx_coco-panoptic.py
for panoptic segmentation.Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist