Skip to content

Conversation

juliafmorgado
Copy link
Contributor

@juliafmorgado juliafmorgado commented Aug 13, 2024

Signed-off-by: Julia Furst Morgado [email protected]

Related to #77

@scottrigby
Copy link
Member

thanks so much! would you please fix the DCO sign-off? The DCO bot check gives step by step instructions. Ping me if i can help with that.

@scottrigby scottrigby mentioned this pull request Aug 14, 2024
Signed-off-by: Julia Furst Morgado <[email protected]>
Signed-off-by: Julia Furst Morgado <[email protected]>
@scottrigby
Copy link
Member

Thanks for fixing DCO - and for noticing this repo's CONTRIBUTING guidelines doens't mention that as a requirement! Our GitHub org's default contributing file does, but the repo-specific one overrides that, so we need to fix that. I opened an issue to track that:

Anyway, we now just need another French speaker to review this PR 😄

Copy link

@lrochette lrochette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

Implement lrochette's recommendations

Signed-off-by: Julia Furst Morgado <[email protected]>
Signed-off-by: Julia Furst Morgado <[email protected]>
Signed-off-by: Julia Furst Morgado <[email protected]>
Signed-off-by: Julia Furst Morgado <[email protected]>
Signed-off-by: Julia Furst Morgado <[email protected]>
Signed-off-by: Julia Furst Morgado <[email protected]>
Signed-off-by: Julia Furst Morgado <[email protected]>
Signed-off-by: Julia Furst Morgado <[email protected]>
Copy link

@lrochette lrochette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @juliafmorgado and @lrochette 🤝 🙌

@scottrigby scottrigby merged commit 8be046e into open-gitops:main Aug 14, 2024
@scottrigby scottrigby linked an issue Jul 16, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitOps principles 1.0 translations

3 participants