Cosign improvements - part 3 #4887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4887 +/- ##
=======================================
Coverage 96.60% 96.60%
=======================================
Files 752 752
Lines 25809 25812 +3
Branches 3411 3412 +1
=======================================
+ Hits 24932 24935 +3
Misses 613 613
Partials 264 264 ☔ View full report in Codecov by Sentry. |
* Added better structure to the email * Used simpler language for accessibility Existing instances unfortunately do not automatically get this improvement, they will have to edit their configuration.
…or not This is necessary to display the right text on the cosign confirmation page, as a form may have email confirmations disabled.
The PDF was including the cosign data/component for version 1 of cosign, which is not compatible at all with v2 (see #4308), causing crashes. Generally this doesn't matter since the PDF is generated right after submission is received and before its cosigned, and we don't usually need to re-generate it except during development.
sergei-maertens
force-pushed
the
feature/4320-cosign-improvements-3
branch
from
2ac376b to
6b7e21a
Compare
vaszig
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4320
Changes
Updated the default cosign request email template, which we cannot do via a data migration without possibly destroying custom templates.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shCommit hygiene