Remove defusedxml.lxml usage from dependencies #3897
Merged
+8
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3897 +/- ##
=======================================
Coverage 96.33% 96.34%
=======================================
Files 711 711
Lines 22252 22252
Branches 2554 2554
=======================================
+ Hits 21436 21438 +2
+ Misses 568 566 -2
Partials 248 248 ☔ View full report in Codecov by Sentry. |
Versions without defusedxml
sergei-maertens
changed the title
sergei-maertens
force-pushed
the
chore/1052-remove-defusedxml
branch
from
0877b54 to
ee63956
Compare
Viicos
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1052
The final dependency (django-camunda) will be upgraded through #3886, which results in us only using defusedxml to defuse the standard library. This is still necessary because xmltodict uses xml.sax/expat as it only supports
defusedexpatrather thandefusedxml.