-
Notifications
You must be signed in to change notification settings - Fork 23
feat: in-process offline flagd resolver #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: in-process offline flagd resolver #74
Conversation
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
ac107d6 to
4b9b12d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 90.55% 91.87% +1.31%
==========================================
Files 8 12 +4
Lines 180 443 +263
==========================================
+ Hits 163 407 +244
- Misses 17 36 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Amazing, thank you! I'll review this as soon as possible. |
Signed-off-by: Cole Bailey <[email protected]>
|
This is great work @colebaileygit, thank you! Will review as soon as possible too. |
beeme1mr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I left a few comments but the logic matches other implementations.
I really appreciate you working on this. It's exciting to see the Python SDK and providers maturing.
...rs/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/in_process.py
Outdated
Show resolved
Hide resolved
...rs/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/in_process.py
Outdated
Show resolved
Hide resolved
...eature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/custom_ops.py
Outdated
Show resolved
Hide resolved
...ture-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/file_watcher.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Cole Bailey <[email protected]>
...ture-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/file_watcher.py
Outdated
Show resolved
Hide resolved
...ture-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/file_watcher.py
Outdated
Show resolved
Hide resolved
...ture-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/file_watcher.py
Show resolved
Hide resolved
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
|
Hey @colebaileygit, would you be interested in joining the org? It makes it easier to coordinate on issues and is an initial step towards becoming a maintainer if that's a goal. I would be happy to sponsor you, but there's certainly no obligation. |
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
|
Had a small battle with CI, but the test suite should be robust now finally 🎉 |
|
I'll give @federicobond a chance to review since he has much more Python experience but it looks good to me. |
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
|
Shall I add this small change into this PR, or keep the two separate since the fractional update is a WIP breaking change? https://github.com/colebaileygit/open-feature-python-sdk-contrib/pull/1/files Now that test-harness is merged this seems cleaner to include |
|
Feel free to include it while we chip away at merging in all the other PRs. I still need to work on the JS implementation. |
feat: fractional custom seed
|
@federicobond @beeme1mr Anything else pending? We are starting to use this internally so being able to have an official versioned release would be amazing. The CI error looks unrelated to the PR and some issue with codecov, so don't know what I can do to solve it unfortunately |
|
I'll review it today and schedule a release if everything looks good. |
This PR
Related Issues
open-feature/flagd#1264
Notes
Follow-up Tasks
How to test