Skip to content

fix: fix types for hints in OTel TracingHook #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gruebel merged 1 commit into from
Mar 26, 2024
Merged

fix: fix types for hints in OTel TracingHook #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hooks/openfeature-hooks-opentelemetry/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ classifiers = [
]
keywords = []
dependencies = [
"openfeature-sdk>=0.4.0",
"openfeature-sdk>=0.6.0",
"opentelemetry-api",
]
requires-python = ">=3.8"
Expand Down
9 changes: 6 additions & 3 deletions hooks/openfeature-hooks-opentelemetry/src/openfeature/contrib/hook/opentelemetry/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import json

from openfeature.flag_evaluation import FlagEvaluationDetails
from openfeature.hook import Hook, HookContext
from openfeature.hook import Hook, HookContext, HookHints
from opentelemetry import trace

OTEL_EVENT_NAME = "feature_flag"
Expand All @@ -15,7 +15,10 @@ class EventAttributes:

class TracingHook(Hook):
def after(
self, hook_context: HookContext, details: FlagEvaluationDetails, hints: dict
self,
hook_context: HookContext,
details: FlagEvaluationDetails,
hints: HookHints,
) -> None:
current_span = trace.get_current_span()

Expand All @@ -39,7 +42,7 @@ def after(
current_span.add_event(OTEL_EVENT_NAME, event_attributes)

def error(
self, hook_context: HookContext, exception: Exception, hints: dict
self, hook_context: HookContext, exception: Exception, hints: HookHints
) -> None:
current_span = trace.get_current_span()
current_span.record_exception(exception)