refactor: add mypy and fix typing issues #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gruebel <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 90.55% 92.99% +2.43%
==========================================
Files 8 9 +1
Lines 180 214 +34
==========================================
+ Hits 163 199 +36
+ Misses 17 15 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gruebel
changed the title
Member
federicobond
left a comment
federicobond
left a comment
There was a problem hiding this comment.
Awesome work @gruebel! I wasn't even aware we were not running mypy here.
hooks/openfeature-hooks-opentelemetry/src/openfeature/contrib/hook/opentelemetry/__init__.py
Show resolved
Hide resolved
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/config.py
Outdated
Show resolved
Hide resolved
Signed-off-by: gruebel <[email protected]>
federicobond
approved these changes
Mar 21, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
mypywas not fun, because of theprotobufgenerated code 🙈