feat: expose sync-metadata, call RPC with (re)connect #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned aepfli, beeme1mr, Kavindu-Dodan, laliconfigcat, liran2000, markphelps, sighphyre, thisthat, thiyagu06 and thomaspoignant
toddbaert
assigned toddbaert and unassigned markphelps, beeme1mr, thisthat, thiyagu06, Kavindu-Dodan, aepfli, thomaspoignant, sighphyre, laliconfigcat and liran2000
toddbaert
force-pushed
the
feat/sync-metadata
branch
from
59b6474 to
bddf91d
Compare
aepfli
approved these changes
Sep 25, 2024
...flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/grpc/GrpcConnector.java
Outdated
Show resolved
Hide resolved
toddbaert
force-pushed
the
feat/sync-metadata
branch
2 times, most recently
from
e61a462 to
3186010
Compare
guidobrei
approved these changes
Sep 26, 2024
toddbaert
force-pushed
the
feat/sync-metadata
branch
from
7a47301 to
494c72a
Compare
|
We should also document this feature within the providers readme - i think this is important to be aware of. |
toddbaert
force-pushed
the
feat/sync-metadata
branch
3 times, most recently
from
0891c8a to
100b3e9
Compare
beeme1mr
reviewed
Sep 27, 2024
| @@ -20,10 +22,11 @@ | |||
| @Slf4j | |||
| @SuppressWarnings({ "PMD.TooManyStaticImports", "checkstyle:NoFinalizer" }) | |||
| public class FlagdProvider extends EventProvider { | |||
| private static final String FLAGD_PROVIDER = "flagD Provider"; | |||
| private static final String FLAGD_PROVIDER = "flagd Provider"; | |||
There was a problem hiding this comment.
Should we drop the provider suffix?
There was a problem hiding this comment.
ya, probably. I'll update.
toddbaert
commented
Sep 30, 2024
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
…s/flagd/resolver/grpc/GrpcConnector.java Co-authored-by: Simon Schrottner <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
…s/flagd/FlagdProvider.java Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
feat/sync-metadata
branch
from
b95d966 to
128c4a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
getSyncMetadataaccessor, and updated when the stream is (re)established, from here it can be used in provider hooks, events, etcPlease note the call logic may look a bit strange, but I think it's optimal. We call the
getMetadataRPC as soon as we initiate the stream, and ignore exceptions. This is because it's very unlikely that the metadata RPC will fail while the stream succeeds, and every attempt to reconnect the stream will also retry the metadata - so we should be good with this pattern. If for some reason the metadata call fails but we connect without an issue, we log it.