chore: wire evaluation ctx to store methods #1273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1273 +/- ##
==========================================
+ Coverage 73.69% 77.50% +3.80%
==========================================
Files 32 20 -12
Lines 3140 1609 -1531
==========================================
- Hits 2314 1247 -1067
+ Misses 717 281 -436
+ Partials 109 81 -28 ☔ View full report in Codecov by Sentry. |
beeme1mr
approved these changes
Apr 5, 2024
toddbaert
approved these changes
Apr 5, 2024
Merged
toddbaert
added a commit
that referenced
this pull request
Apr 10, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.10.0</summary> ## [0.10.0](flagd/v0.9.2...flagd/v0.10.0) (2024-04-10) ### ⚠ BREAKING CHANGES * allow custom seed when using targetingKey override for fractional op ([#1266](#1266)) * This is a breaking change only to the extent that it changes the assignment of evaluated flag values. Previously, flagd's `fractional` op would internally concatenate any specified bucketing property with the `flag-key`. This improved apparent "randomness" by reducing the chances that users were assigned a bucket of the same ordinality across multiple flags. However, sometimes it's desireable to have such predictibility, so now **flagd will use the bucketing value as is**. If you are specifying a bucketing value in a `fractional` rule, and want to maintain the previous assignments, you can do this concatenation manually: `{ "var": "user.name" }` => `{"cat": [{ "var": "$flagd.flagKey" }, { "var": "user.name" }]}`. This will result in the same assignment as before. Please note, that if you do not specify a bucketing key at all (the shorthand version of the `fractional` op), flagd still uses a concatentation of the `flag-key` and `targetingKey` as before; this behavior has not changed. ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.8.2 ([#1255](#1255)) ([9005089](9005089)) ### ✨ New Features * allow custom seed when using targetingKey override for fractional op ([#1266](#1266)) ([f62bc72](f62bc72)) ### 🧹 Chore * refactor evaluation core ([#1259](#1259)) ([0e6604c](0e6604c)) * update go deps ([#1279](#1279)) ([219789f](219789f)) </details> <details><summary>flagd-proxy: 0.6.0</summary> ## [0.6.0](flagd-proxy/v0.5.2...flagd-proxy/v0.6.0) (2024-04-10) ### ⚠ BREAKING CHANGES * allow custom seed when using targetingKey override for fractional op ([#1266](#1266)) * This is a breaking change only to the extent that it changes the assignment of evaluated flag values. Previously, flagd's `fractional` op would internally concatenate any specified bucketing property with the `flag-key`. This improved apparent "randomness" by reducing the chances that users were assigned a bucket of the same ordinality across multiple flags. However, sometimes it's desireable to have such predictibility, so now **flagd will use the bucketing value as is**. If you are specifying a bucketing value in a `fractional` rule, and want to maintain the previous assignments, you can do this concatenation manually: `{ "var": "user.name" }` => `{"cat": [{ "var": "$flagd.flagKey" }, { "var": "user.name" }]}`. This will result in the same assignment as before. Please note, that if you do not specify a bucketing key at all (the shorthand version of the `fractional` op), flagd still uses a concatentation of the `flag-key` and `targetingKey` as before; this behavior has not changed. ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.8.2 ([#1255](#1255)) ([9005089](9005089)) ### ✨ New Features * allow custom seed when using targetingKey override for fractional op ([#1266](#1266)) ([f62bc72](f62bc72)) ### 🧹 Chore * update go deps ([#1279](#1279)) ([219789f](219789f)) </details> <details><summary>core: 0.9.0</summary> ## [0.9.0](core/v0.8.2...core/v0.9.0) (2024-04-10) ### ⚠ BREAKING CHANGES * allow custom seed when using targetingKey override for fractional op ([#1266](#1266)) * This is a breaking change only to the extent that it changes the assignment of evaluated flag values. Previously, flagd's `fractional` op would internally concatenate any specified bucketing property with the `flag-key`. This improved apparent "randomness" by reducing the chances that users were assigned a bucket of the same ordinality across multiple flags. However, sometimes it's desireable to have such predictibility, so now **flagd will use the bucketing value as is**. If you are specifying a bucketing value in a `fractional` rule, and want to maintain the previous assignments, you can do this concatenation manually: `{ "var": "user.name" }` => `{"cat": [{ "var": "$flagd.flagKey" }, { "var": "user.name" }]}`. This will result in the same assignment as before. Please note, that if you do not specify a bucketing key at all (the shorthand version of the `fractional` op), flagd still uses a concatentation of the `flag-key` and `targetingKey` as before; this behavior has not changed. ### ✨ New Features * allow custom seed when using targetingKey override for fractional op ([#1266](#1266)) ([f62bc72](f62bc72)) ### 🧹 Chore * refactor evaluation core ([#1259](#1259)) ([0e6604c](0e6604c)) * update go deps ([#1279](#1279)) ([219789f](219789f)) * wire evaluation ctx to store methods ([#1273](#1273)) ([0075932](0075932)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
A follow-up to #1259 where binds context from evaluation request to store contract (passing context to
evaluateVariant())No changes for evaluation logic or any other component