-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Improved error messages #1100
Labels
contribfest
A good issue for Contribfest KubeCon EU '24
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Comments
Hi, @toddbaert could you tell how exactly the error message should be ? |
Hey @Baalekshan, the idea would be to map the error codes to more human-readable error messages. For example, "FlagdError:, FLAG_NOT_FOUND" could be "Flag not found" |
if this issue is still up for grabs ill take it |
Reassigning. |
toddbaert
added a commit
that referenced
this issue
Jun 18, 2024
- Mapped the error codes to easier to read error messages - Created unit test to check functionality #1100 --------- Signed-off-by: DBlanchard88 <[email protected]> Signed-off-by: Dave <[email protected]> Co-authored-by: Todd Baert <[email protected]>
Fixed by #1325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
contribfest
A good issue for Contribfest KubeCon EU '24
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Problem
The error messages we get back from the flagd evaluation API are less than ideal. They are an odd concatenation of an empty string and error code (see "message" below):
Requirements
Investigate the possibility of sending a better error message (should not be breaking - client code should use the
code
not the messages).The text was updated successfully, but these errors were encountered: