feat: allow custom seed in fractional op #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cole Bailey <[email protected]>
Signed-off-by: Cole Bailey <[email protected]>
beeme1mr
reviewed
Apr 1, 2024
beeme1mr
approved these changes
Apr 2, 2024
Member
beeme1mr
left a comment
beeme1mr
left a comment
There was a problem hiding this comment.
Approving but I would like to wait for @toddbaert to approve before we merge.
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Kavindu-Dodan
approved these changes
Apr 8, 2024
toddbaert
approved these changes
Apr 8, 2024
Merged
beeme1mr
pushed a commit
that referenced
this pull request
Apr 8, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>json/json-schema: 0.2.3</summary> ## [0.2.3](json/json-schema-v0.2.2...json/json-schema-v0.2.3) (2024-04-08) ### ✨ New Features * allow custom seed in fractional op ([#136](#136)) ([ea4f119](ea4f119)) * support chainable if conditions ([#138](#138)) ([cc7832a](cc7832a)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
catand other rules to provide custom seeds to randomisationRelated Issues
open-feature/flagd#1264
resolves open-feature/flagd#1265
Notes
Follow-up Tasks
How to test
see open-feature/flagd#1266