build: Change dependency assets #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 39 39
Lines 1603 1603
Branches 171 171
=======================================
Hits 1374 1374
Misses 191 191
Partials 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kylejuliandev
approved these changes
Apr 14, 2025
beeme1mr
approved these changes
Apr 14, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
Signed-off-by: André Silva <[email protected]> <!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> This pull request updates the Renovate configuration to enhance dependency management workflows. The most notable changes include enabling dependency dashboard approval and specifying that dependencies should not be recreated automatically. Changes to Renovate configuration: * [`renovate.json`](diffhunk://#diff-7b5c8955fc544a11b4b74eddb4115f9cc51c9cf162dbffa60d37eeed82a55a57L5-R7): Enabled the `dependencyDashboardApproval` setting to require manual approval for dependency updates. * [`renovate.json`](diffhunk://#diff-7b5c8955fc544a11b4b74eddb4115f9cc51c9cf162dbffa60d37eeed82a55a57L5-R7): Added the `recreateWhen` setting with a value of `"never"` to prevent automatic recreation of dependency updates. ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> Fixes #448 ### Notes <!-- any additional notes for this PR --> I followed Renovate's general recommendation. I also changed to require dashboard manual approval because we don't want the PRs to pop up for dotnet extensions (they should be closed since we need to publish the lowest version compatible; see #426). So we should look into the dashboard issue #92 to create the PRs for dependencies. Signed-off-by: André Silva <[email protected]>
WeihanLi
pushed a commit
to WeihanLi/openfeature-dotnet-sdk
that referenced
this pull request
May 14, 2025
<!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> This pull request includes updates to the `Directory.Packages.props` file to centralize and manage package versions more effectively, particularly for Microsoft Extensions packages. Key changes include: * Added a new property `MicrosoftExtensionsVersion` with a default value of `8.0.0` and a conditional value of `9.0.0` for `net9.0` target framework. * Updated `PackageVersion` elements to use the new `MicrosoftExtensionsVersion` property instead of hardcoded version numbers. ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> Fixes open-feature#424 ### Notes <!-- any additional notes for this PR --> I tried to follow the https://github.com/App-vNext/Polly approach to determining the dependencies we should bring in. It seems that all the major libraries depend on the lowest version of the target framework. For example, if the target is net 8.0, the package will be 8.0.0. If the target is net 9.0, the package will be 9.0.0. Thanks, @kylejuliandev, for the discussion and the examples in Slack. --------- Signed-off-by: André Silva <[email protected]> Signed-off-by: Weihan Li <[email protected]>
WeihanLi
pushed a commit
to WeihanLi/openfeature-dotnet-sdk
that referenced
this pull request
May 14, 2025
Signed-off-by: André Silva <[email protected]> <!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> This pull request updates the Renovate configuration to enhance dependency management workflows. The most notable changes include enabling dependency dashboard approval and specifying that dependencies should not be recreated automatically. Changes to Renovate configuration: * [`renovate.json`](diffhunk://#diff-7b5c8955fc544a11b4b74eddb4115f9cc51c9cf162dbffa60d37eeed82a55a57L5-R7): Enabled the `dependencyDashboardApproval` setting to require manual approval for dependency updates. * [`renovate.json`](diffhunk://#diff-7b5c8955fc544a11b4b74eddb4115f9cc51c9cf162dbffa60d37eeed82a55a57L5-R7): Added the `recreateWhen` setting with a value of `"never"` to prevent automatic recreation of dependency updates. ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> Fixes open-feature#448 ### Notes <!-- any additional notes for this PR --> I followed Renovate's general recommendation. I also changed to require dashboard manual approval because we don't want the PRs to pop up for dotnet extensions (they should be closed since we need to publish the lowest version compatible; see open-feature#426). So we should look into the dashboard issue open-feature#92 to create the PRs for dependencies. Signed-off-by: André Silva <[email protected]> Signed-off-by: Weihan Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This pull request includes updates to the
Directory.Packages.propsfile to centralize and manage package versions more effectively, particularly for Microsoft Extensions packages.Key changes include:
MicrosoftExtensionsVersionwith a default value of8.0.0and a conditional value of9.0.0fornet9.0target framework.PackageVersionelements to use the newMicrosoftExtensionsVersionproperty instead of hardcoded version numbers.Related Issues
Fixes #424
Notes
I tried to follow the https://github.com/App-vNext/Polly approach to determining the dependencies we should bring in. It seems that all the major libraries depend on the lowest version of the target framework.
For example, if the target is net 8.0, the package will be 8.0.0. If the target is net 9.0, the package will be 9.0.0.
Thanks, @kylejuliandev, for the discussion and the examples in Slack.