Skip to content

feat: update FeatureLifecycleStateOptions.StopState default to Stopped #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beeme1mr merged 2 commits into from
Apr 1, 2025
Merged

feat: update FeatureLifecycleStateOptions.StopState default to Stopped #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5829d60
feat: update FeatureLifecycleStateOptions.StopState default to Stopped
WeihanLi Mar 31, 2025
fd25157
refactor: remove the default option configure
WeihanLi Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OpenFeature.Hosting/FeatureLifecycleStateOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ public class FeatureLifecycleStateOptions
/// <summary>
/// Gets or sets the state during the feature shutdown lifecycle.
/// </summary>
public FeatureStopState StopState { get; set; } = FeatureStopState.Stopping;
public FeatureStopState StopState { get; set; } = FeatureStopState.Stopped;
}
10 changes: 1 addition & 9 deletions src/OpenFeature.Hosting/OpenFeatureBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,7 @@ public static partial class OpenFeatureBuilderExtensions
/// <returns>The <see cref="OpenFeatureBuilder"/> instance.</returns>
public static OpenFeatureBuilder AddHostedFeatureLifecycle(this OpenFeatureBuilder builder, Action<FeatureLifecycleStateOptions>? configureOptions = null)
{
if (configureOptions == null)
{
builder.Services.Configure<FeatureLifecycleStateOptions>(cfg =>
{
cfg.StartState = FeatureStartState.Starting;
cfg.StopState = FeatureStopState.Stopping;
});
}
else
if (configureOptions is not null)
{
builder.Services.Configure(configureOptions);
}
Expand Down