chore: migrate away from SpecFlow to ReqnRoll for BDD E2E tests#356
Merged
askpt merged 7 commits intoopen-feature:mainfrom Apr 23, 2025
Merged
Conversation
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
* FlagNotFoundException is never thrown in Flagd nor in the base SDK itself. Not sure how this test was passing before but I've updated the exception to use the actual one Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Contributor
Author
|
I'll rerun dotnet format when I get some time later today |
* After upgrading XUnit a bunch of new warnings were added. CI fails with these so I have fixed those warnings. They mostly concern incorrectly using async Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
beeme1mr
approved these changes
Apr 23, 2025
Member
|
Sorry @kylejuliandev for all the merge conflicts! 🙈 |
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
weyert
pushed a commit
to weyert/dotnet-sdk-contrib
that referenced
this pull request
May 30, 2025
…-feature#356) Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com> Co-authored-by: André Silva <2493377+askpt@users.noreply.github.com> Signed-off-by: Weyert de Boer <weyert@innerfuse.biz>
weyert
pushed a commit
to weyert/dotnet-sdk-contrib
that referenced
this pull request
Jun 19, 2025
…-feature#356) Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com> Co-authored-by: André Silva <2493377+askpt@users.noreply.github.com>
weyert
pushed a commit
to weyert/dotnet-sdk-contrib
that referenced
this pull request
Jun 19, 2025
…-feature#356) Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com> Co-authored-by: André Silva <2493377+askpt@users.noreply.github.com> Signed-off-by: Weyert de Boer <weyert@innerfuse.biz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #346
Notes
ReqnRoll complained about async void (antipattern anyway), so I've updated those steps to use async Task instead.
Follow-up Tasks
How to test