Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix right value on update strategy #233

Merged
merged 1 commit into from
Aug 29, 2017
Merged

fix right value on update strategy #233

merged 1 commit into from
Aug 29, 2017

Conversation

milkwine
Copy link
Contributor

the same as #173

@jojohappy
Copy link
Contributor

jojohappy commented Aug 26, 2017 •
edited
Loading

@sawater PR #173 has been merged

@laiwei laiwei closed this Aug 26, 2017
@milkwine
Copy link
Contributor Author

更新的有修复吗？

@laiwei
Copy link
Member

laiwei commented Aug 28, 2017

@sawater #173 中已经修复了，有问题，请reopen。

@milkwine
Copy link
Contributor Author

falcon-plus/modules/api/app/controller/strategy/strategy_controller.go

Line 138 in 1d89dc0

validRightValue := regexp.MustCompile(`^\d+$`)

@laiwei laiwei reopened this Aug 29, 2017
laiwei
laiwei approved these changes Aug 29, 2017
View reviewed changes
Copy link
Member

@laiwei laiwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create 和 update 都需要修改，之前看错了:)

@laiwei laiwei merged commit 5f03420 into open-falcon:master Aug 29, 2017
@milkwine milkwine deleted the fix_right_value_on_update branch March 14, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laiwei laiwei laiwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milkwine @jojohappy @laiwei