-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic PR labelling action #109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodutu
added
area/infra
Update to infrastructure / scripts
kind/new
New content / item
labels
Jan 23, 2023
teodutu
force-pushed
the
add-labeler
branch
5 times, most recently
from
January 23, 2023 19:40
01056c2
to
4e75bc9
Compare
.github/workflows/labeler.yml
Outdated
@@ -0,0 +1,24 @@ | |||
name: "Pull Request Labeler" | |||
on: [pull_request] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
teodutu
removed
area/infra
Update to infrastructure / scripts
kind/new
New content / item
labels
Jan 23, 2023
teodutu
force-pushed
the
add-labeler
branch
2 times, most recently
from
January 23, 2023 20:12
6f68f14
to
35ada1e
Compare
I tested the scripts with a PR in my own fork, where the |
gabrielmocanu
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can integrate this.
Signed-off-by: Teodor Dutu <[email protected]>
We need this one faster |
teodutu
added a commit
to teodutu/operating-systems
that referenced
this pull request
Oct 21, 2024
Set the variables `remove`, `replace_pairs`, and `end_string` for `.d` files so they are defined when calling the `process_file()` function. Fixes: open-education-hub#109 Signed-off-by: Teodor Dutu <[email protected]>
teodutu
added a commit
to teodutu/operating-systems
that referenced
this pull request
Oct 21, 2024
- Set the variables `remove`, `replace_pairs`, and `end_string` for `.d` files so they are defined when calling the `process_file()` function. - Add check in `process_file()` if any of `pattern`, `replace`, or `remove` are null and issue an error if so. Fixes: open-education-hub#109 Signed-off-by: Teodor Dutu <[email protected]>
teodutu
added a commit
to teodutu/operating-systems
that referenced
this pull request
Oct 21, 2024
- Set the variables `remove`, `replace_pairs`, and `end_string` for `.d` files so they are defined when calling the `process_file()` function. - Add check in `process_file()` if any of `pattern`, `replace`, or `remove` are null and issue an error if so. Fixes: open-education-hub#109 Signed-off-by: Teodor Dutu <[email protected]>
teodutu
added a commit
to teodutu/operating-systems
that referenced
this pull request
Oct 22, 2024
- Set the variables `remove`, `replace_pairs`, and `end_string` for `.d` files so they are defined when calling the `process_file()` function. - Add check in `process_file()` if any of `pattern`, `replace`, or `remove` are null and issue an error if so. Fixes: open-education-hub#109 Signed-off-by: Teodor Dutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
labeler
for assigningtopic/*
andarea/*
labels and a custom script forkind/*
labels.kind/new
is assigned to any PR that contains a newly added file andkind/improvement
is assigned to any PR that contains at least one file only with additions. Thestudent-contrib
andkind/fix
labels are to be added manually.Fixes #89.
Signed-off-by: Teodor Dutu [email protected]