Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math/seadQuatCalc: Add missing includes #142

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

MonsterDruide1
Copy link
Contributor

@MonsterDruide1 MonsterDruide1 commented Aug 7, 2024

This is the last PR of a series of PRs across all libraries, which will try to fix more issues with the current headers by introducing a new workflow on the OdysseyDecomp repo. As of right now, trying to compile certain combinations of headers or singular headers individually will fail, due to a number of reasons: Duplicate definitions, stubs that should have been replaced by including their proper definition, includes missing altogether and maybe more.

For this repo, only two includes were missing: seadQuatCalcCommon.h makes use of the f32 type in slerpTo without previously defining it, so it should include basis/seadTypes.h. The implementation .hpp file uses VectorCalcCommon in makeVectorRotation, so it should include math/seadVectorCalcCommon.h as well.


This change is Reviewable

@ThePixelGamer ThePixelGamer merged commit 0d3ad57 into open-ead:master Aug 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants