GameFrameworkNx: Add member variables #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePixelGamer
requested changes
Jul 25, 2024
| @@ -7,6 +7,21 @@ | |||
|
|
|||
| namespace sead | |||
| { | |||
|
|
|||
| class DisplayBufferNvn; | |||
There was a problem hiding this comment.
I'm unsure if I prefer this over just an include though I don't think that should block this PR, @leoetlino I would like your opinion
There was a problem hiding this comment.
I just did that from habit since we do that for smo
|
About adding more info: I can add more info from the ctor, but @MonsterDruide1 suggested just adding one line for a filler, so idk |
|
Having fillers is fine tbh, I just looked at the constructor myself and noticed a bunch of small details that could be included in this PR (floats, sead::SafeString, other structs/array memcpys) |
added 2 commits
July 25, 2024 21:20
ThePixelGamer
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SMO's
al::GameFrameworkNxrequires theseadone to have the correct size. Besides filling the struct with the correct size, I also added some names and types based on @MonsterDruide1 's structThis change is