Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math: Add u32 variant to Vectors #137

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

MonsterDruide1
Copy link
Contributor

@MonsterDruide1 MonsterDruide1 commented May 9, 2024

There seems to be another, very rarely used variant of the sead::Vector type, containing an uint/u32 as elements.

In SMO, it can be observed in a bunch of al::KCollisionServer symbols, along with al::Dynamic{Mesh, DrawActor, MeshDrawer}. There also seems to be a single occurence in agl::detail::SMAAResTextureGenerator::calcSearchEdgeFromKey.

I can confirm that at least the Vector3u and Vector4u variants exist, I didn't find an occurence of Vector2u though - I find it very likely to exist as well though.


This change is Reviewable

Copy link
Contributor

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me

@leoetlino leoetlino merged commit ae518fa into open-ead:master Jun 6, 2024
1 check passed
@MonsterDruide1 MonsterDruide1 deleted the vectoru branch June 18, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants