Move GameFrameworkNx and DebugFontMgrNvn for correct file layout
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonsterDruide1
force-pushed
the
troy-reorder
branch
from
b5671f7
to
0f38deb
Compare
|
Might close #128 ? |
break-core
reviewed
Aug 22, 2023
There was a problem hiding this comment.
Looks good! Also, for skeptical maintainers, these file paths were sourced from MK8DX:
D:/home/Project/TurboS/App/Lib/sead/library/modules/src/framework/nx/seadGameFrameworkNx.cpp
D:/home/Project/TurboS/App/Lib/sead/library/modules/src/gfx/nvn/seadDebugFontMgrNvn.cpp
Reviewable status: 0 of 6 files reviewed, all discussions resolved
|
@break-core Does this fully cover the second point you described in the issue? I was confused by your sentence about merging stuff... |
|
@MonsterDruide1 Yes, this should fully cover that. Everything looks to be correct, sorry about any confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving around some of the files according to some messages in the Discord-Server:
https://discord.com/channels/688807550715560050/794951602396987432/1115848275581485107
(not directly quoted, but adjusted/corrected according to later messages)
This change is