Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

framework: Add sead::Task header #130

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

Sanae6
Copy link
Contributor

@Sanae6 Sanae6 commented Jul 29, 2023

Added a header for sead::Task.


This change is Reviewable

@Sanae6 Sanae6 changed the title Add header for sead::Task framework: Add sead::Task header Jul 29, 2023
@aboood40091
Copy link
Collaborator

aboood40091 commented Jul 29, 2023

I have never heard of sead::Task. Do you have a source for that?

EDIT: Apparently it IS a thing, which I see in the MK8 symbol map, but it does not seem to be used there at least. Do you know something that uses it?

@Sanae6
Copy link
Contributor Author

Sanae6 commented Jul 29, 2023

@aboood40091 I found sead::Task in SMO.
RootTask, a critical part of early startup code, depends on it.
javaw_zm6SO1493Z

Sanae6 added a commit to odyssey-modding/odyssey that referenced this pull request Aug 2, 2023
Sanae6 added a commit to odyssey-modding/odyssey that referenced this pull request Aug 3, 2023
Ruins RootTask header temporarily to fix project compilation, waiting
for open-ead/sead#130 to be merged.
@ThePixelGamer ThePixelGamer merged commit 19d98a9 into open-ead:master Aug 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants