fix: preserve async listeners with ".once()" #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kettanaito
commented
Sep 21, 2023
kettanaito
commented
- Discovered in fix(ClientRequest): ignore request destroyed state when responding with a mocked response mswjs/interceptors#432
kettanaito
commented
Sep 21, 2023
| * @note Return the result of the original listener. | ||
| * This way this wrapped preserves listeners that are async. | ||
| */ | ||
| return listener.apply(this, data) |
There was a problem hiding this comment.
By returning this listener call, this wrapped will respect the sync/async nature of the original listener, and can, itself, be awaited.
Released: v0.5.1 🎉This has been released in v0.5.1! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.