feat: Added integration test workflow action - #4
Conversation
Kelketek
left a comment
Kelketek
left a comment
There was a problem hiding this comment.
@sathiscode Glad to find you were able to locate code that can install and run the platform. Left some comments that should get you in the direction of making this work as expected for the team.
Agrendalath
left a comment
Agrendalath
left a comment
There was a problem hiding this comment.
@sathiscode, the CI is currently failing.
f2352d0 to
d729c4a
Compare
24cdfa5 to
9e27803
Compare
|
@sathiscode Have you rebased to the latest master of the repo? I just realized the unit tests will certainly fail against upstream master currently since this PR isn't merged. But Nutmeg should pass if you're up to date, I'd think. |
@Kelketek Yes, I also just realized that upstream merge has not happened. The test are failing for both master & nutmeg. For nutmeg, are we expected always pull changes from |
You'll just want to check out that branch directly-- you don't need to do anything to reconsile it with upstream. Upstream's nutmeg.2 branch is frozen. Our branch is based on it. If upstream cuts a revised Nutmeg branch, it will be called nutmeg.3, and we'll go through a process of rebasing our changes on it for our own Nutmeg.3 branch and then we'll need to update the target test branch here-- all of which is outside of the scope of this PR. All you have to do right now is test against Nutmeg.2. For now, let's comment out the master tests, and just do tests against our own Nutmeg branch. Then I'll do a follow up when the upstream master PR is merged. |
733ebf7 to
371a43a
Compare
|
@Kelketek Sounds good. I'll make the changes and request for code review. |
371a43a to
620a9a9
Compare
sathiscode
changed the title
Integration test workflow action is added to run automatically on PR.
4fc19db to
799548a
Compare
Agrendalath
left a comment
Agrendalath
left a comment
There was a problem hiding this comment.
👍
- I tested this: checked that the integration tests are passing
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
3 participants
Unit test workflow action is added to run automatically on PR
Merge checklist:
Check off if complete or not applicable:
This workflow runs automatically on any PR and the results can be viewed in "Actions" table at the top of this page.
Note:
The branch name of
section-to-courserepo has to matchedx-platformrepo branch name. For example,section-to-courserepo PR on branchopen-release/nutmeg.masterwill be validated againstopen-release:nutmeg.masterbranch ofedx-platfom.The CI run will fail as this PR is to merge againstsection-to-courserepomainbranch. But there is nomainbranch inedx-platformrepo.Edit:
The CI run will fail asopen-craft/opencraft-release/nutmeg.2is not yet merged upstream.2nd Edit:
The CI is updated to run only for nutmeg release. The master run is removed as the upstream changes are yet to be pushed.