feat: Initial copy-paste circuit - #1
Conversation
4ae769f to
bc0c1a1
Compare
|
@Agrendalath This is ready for another look! |
Agrendalath
left a comment
There was a problem hiding this comment.
When I clone the section into a new course, the subsections are not displayed on the Course Outline page. Do we need to refresh learning sequences manually to get it working? When I go to the [/admin/learning_sequences/coursecontext/](http://localhost:18000/admin/learning_sequences/coursecontext/) page, I don't see any sequences in the "Debug Details".
Also, we will need to backport the upstream PR to our Nutmeg branch and test it there before we merge this, right?
@Agrendalath I'm not able to reproduce this issue-- when I copy the section over and then refresh the learning MFE page, I see the new section in the outline. Can you give me step-by-step instructions to reproduce? As for backporting the upstream branch, probably! We can make sure to clear that out first. I'll start the next task based on this branch while we wait on that merge. If it takes long enough we'll just put the commit into our Nutmeg branch while we wait. Or, if you think it would be better, I can create the PR against our nutmeg branch now. I've addressed the remaining notes-- could you take one more look? |
I just followed your testing instructions for the first section of the demo course. It might be something with my devstack.
What are we waiting for? I already left my +1 and asked you in Jira if you want me to merge it now or wait for the Nutmeg testing.
Yeah, we will deploy this to a Nutmeg instance, so let's do it now. We also won't need to worry about the Learning Sequences while rendering the Course Outline page.
I'm still seeing a couple of unresolved discussions (example). They are marked as "outdated", so you may need to open them manually. They are still valid, though. |
Sorry, forgot you had merge rights on edx-platform. I'll create the MR against our Nutmeg branch.
I've made a push to fix up the README. I didn't see any other outstanding discussions than the one you mentioned, though. If there are more, can you ping me on them? |
|
Damn, the sheer amount of boilerplate required in a new django app for Open edX is truly gross. |
|
@Agrendalath I went to backport the changes to Nutmeg and found that the structure/location of items in the code changed much more than I had anticipated. The most recent changes should allow the app to be installed and used in both versions while also allowing the quality tests to work. Also, looks like @bradenmacdonald has just added new review notes on the code in edx-platform, so this changes things-- looks like I still have a bit left to go there. |
|
@Agrendalath The changes requested by Braden upstream are pretty involved, but I'm expecting the end result will have the same data structures. So, I don't think we need to hold up this PR for it if we juggle things a bit. Here's how I propose we move forward so the project doesn't fall behind but we still get all adjustments made: 1.We'll install and run this based on the backported PR to nutmeg. I've added a note into the README about the need to use our Nutmeg branch for now. |
|
@Kelketek I didn't realize any of my feedback would be "pretty involved", so feel free to discuss it more on that upstream PR first if you think it can save you some work. |
I see the following discussions:
Is this step ready for review? |
docs: Several typographical improvements. Co-authored-by: Piotr Surowiec <piotr@surowiec.it>
3b4ea77 to
54b1b32
Compare
|
Thanks, @Agrendalath . I'm not sure why they weren't appearing for me earlier. I've added the workflows back, and the docs, which I've updated. Of course as you know, most of these will fail at the moment until Sathis completes the CI changes needed.
Yes. |
|
@Kelketek, by this comment, I meant restoring the CHANGELOG.rst, not the whole
Did I miss something? What changes are you referring to? |
This reverts commit 2019cf2.
I know you didn't mean this-- I had elected to pull it back in since a bunch of small snippets were referring to the docs so I put it back in, since it seemed very 'may as well'. But you're right, it's verbose. I've re-removed it.
Possibly. Here's a recap: Back in Columbia I had spoken with Braden asking them if there was any current CI solution to apps like this, which rely on platform internals to run. His answer was that he knew of none and it's a continued issue. This is why I removed most of the workflows. Once I submitted this PR though, you mentioned you want us to find a way to get CI running anyway. But that's a sizable project, so I scheduled a follow-up ticket, which is currently assigned to Sathis. |
Ok, I see that you didn't add this ticket to any epic, so that's why I couldn't find it. Also, you added me as a reviewer while creating a ticket, so I didn't get any notification. IIRC, Jira sends the message if you do the assignments as a separate step. |
|
Great. @Agrendalath was there anything else you needed addressed on this PR? Did we want to move forward with merging it in anticipation of running it with the Nutmeg branch? |
|
@Agrendalath Ping! See above question. :) |
Requirement files should not depend on devpi.
Agrendalath
left a comment
There was a problem hiding this comment.
See my review comment before merging.
👍
- I tested this: followed the testing instructions
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: not yet
⚠️ - I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
|
|
||
| Allows course authors to factor sections from Open edX courses into their own new course. | ||
|
|
||
| Check the `docs directory <docs/>`_ for details on how to set up and configure this application. |
There was a problem hiding this comment.
I suppose you forgot to add these back.
78478e7 to
3863732
Compare
3863732 to
3e3c847
Compare
|
@Agrendalath Went ahead and added the instructions to the README. If you find any issue with them, I'll go ahead and fix it in #2 . Merging now. |
|
@Agrendalath I realized after I merged this that I forgot to squash, so since we haven't deployed yet I went ahead and did so on master. Not something I anticipate being able to do again. cc @sathiscode |

This PR creates the initial scaffolding for the section_to_course application.
JIRA tickets: https://tasks.opencraft.com/browse/BB-7295
Dependencies: openedx/openedx-platform#32058
Testing instructions:
To set up the app:
srcdirectory of the devstack, clone this repository and checkout this branch.devstackrepo root, runmake dev.shell.studiocd /edx/src/section_to_coursepip install -e .To run the unit tests:
devstackrepo root, runmake dev.shell.studioDJANGO_SETTINGS_MODULE=cms.envs.test pytest --pyargs section_to_course --rootdir cmsTo test the functionality manually:
devstackrepo root, runmake dev.shell.studiosection_to_courseand should be followed by the destination course and the source section's usage key. For example,./manage.py cms section_to_course course-v1:Beeper+B33P+BOOP block-v1:edX+DemoX+Demo_Course+type@chapter+block@graded_interactions edx.Author notes and concerns:
The cookiecutter we derived from had a lot of nice CI functionalities, not to mention linting. I had to discard all of it since we rely on the edx-platform environment and can't (readily) import that into the GitHub CI. So, please be attentive to code quality when reviewing.