fix: handle missing discussion settings when importing old courses - #736
Merged
Agrendalath merged 2 commits intoOct 16, 2025
Merged
Conversation
Member
|
@Agrendalath Seems like the upstream PR has been closed, because the fix has been implemented and merged in a different PR. Can we close this PR and drop it? |
Agrendalath
force-pushed
the
agrendalath/fix-syncing-discussing-settings
branch
from
October 8, 2025 16:36
7a8199e to
f15c74f
Compare
Agrendalath
force-pushed
the
agrendalath/fix-syncing-discussing-settings
branch
from
October 8, 2025 16:36
f15c74f to
1120312
Compare
Member
Author
|
@Cup0fCoffee, we shouldn't drop it - instead, we should revert 8612f2a and backport the fix to our branch. I updated this PR. Since it's a clean backport, it should be okay to merge it once the CI passes. |
… type in course Both 'provider' and 'provider_type' have been used for storing the discussion provider type in course 'discussions_settings' field, there are some places in the code checking for 'provider' and others checking for 'provider_type', in some cases this can cause a bug where it doesn't detect the correct provider which causes discussion settings not being copied correctly when a course is cloned. This change prioritises the `provider_type` setting over `provider` and reads `provider` only as a fallback. The `provider` setting is now made read-only just for backwards-compatibility, to avoid confusion. (cherry picked from commit 9ee4afa)
Cup0fCoffee
force-pushed
the
agrendalath/fix-syncing-discussing-settings
branch
from
October 14, 2025 18:02
1120312 to
18e2d56
Compare
Cup0fCoffee
approved these changes
Oct 14, 2025
Agrendalath
merged commit Oct 16, 2025
6f64f13
into
opencraft-release/redwood.1
16 of 77 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a Redwood backport of openedx#36211.