Skip to content

Update collections crud rest api - #683

Merged
pomegranited merged 4 commits into
yusuf-musleh/collections-crud-rest-apifrom
chris/update-collections-crud-rest-api
Sep 11, 2024
Merged

Update collections crud rest api#683
pomegranited merged 4 commits into
yusuf-musleh/collections-crud-rest-apifrom
chris/update-collections-crud-rest-api

Conversation

@ChrisChV

@ChrisChV ChrisChV commented Sep 10, 2024

Copy link
Copy Markdown
Member
  • Update description as optional: 3c79543
  • Update create collection API to auto-generate key: 8118b77

@rpenido rpenido left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work, @ChrisChV!
I think it is missing the handler to update the search index after creating a collection. If you feel this should be done in another task, make sure that you create one for it (I didn't find any).

@pomegranited pomegranited left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @ChrisChV Thank you for proposing this solution. I'm ok with this change -- since we added Collection.key late in the game, there's no explicit requirement to let users enter their own key, and we're under some time pressure here.

  • I tested this on my tutor devstack with openedx/frontend-app-authoring#1260
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

@pomegranited
pomegranited merged commit 48a1667 into yusuf-musleh/collections-crud-rest-api Sep 11, 2024
@pomegranited
pomegranited deleted the chris/update-collections-crud-rest-api branch September 11, 2024 01:15
@pomegranited

Copy link
Copy Markdown

@rpenido

I think it is missing the handler to update the search index after creating a collection. If you feel this should be done in another task, make sure that you create one for it (I didn't find any).

I created this ticket for that: openedx/frontend-app-authoring#1260

Trying to get it done under FAL-3817, but will see.

pomegranited pushed a commit that referenced this pull request Sep 11, 2024
* Update description as optional in ContentLibraryCollectionUpdateSerializer
* Create collection Rest API to auto-generate key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants