fix: remove incorrect key type when filtering inaccessible blocks - #681
Merged
farhaanbukhsh merged 1 commit intoJan 23, 2025
Merged
Conversation
Member
|
@Agrendalath What is the plan for this PR? I've experienced the same issue with one of my clients, which can be replicated by adding a section with subsection, publishing, then removing the subsections (making the section empty), and publishing again. I think the side effect was that one of the new features (the outline) in LMS was broken. |
Member
Author
|
@Cup0fCoffee, I plan to merge it after wrapping up the upstream PR. I randomly noticed this error in the logs when debugging an issue around the timed exams, but I didn't notice any learner-facing errors caused by this. |
Agrendalath
force-pushed
the
agrendalath/fix-incorrect-key-type
branch
from
December 16, 2024 18:25
3a169e6 to
530ba05
Compare
Agrendalath
marked this pull request as ready for review
January 13, 2025 23:36
Agrendalath
force-pushed
the
agrendalath/fix-incorrect-key-type
branch
from
January 13, 2025 23:36
530ba05 to
d83072b
Compare
Returning the list with a 'completion' string was added in 9bc0f85. However, the `get_accessible_sequences` method expects a list of dicts with an 'id' key.
Agrendalath
force-pushed
the
agrendalath/fix-incorrect-key-type
branch
from
January 20, 2025 20:03
d83072b to
f3c8cba
Compare
farhaanbukhsh
approved these changes
Jan 23, 2025
farhaanbukhsh
left a comment
farhaanbukhsh
left a comment
Member
There was a problem hiding this comment.
👍
- ✅ I tested this on Tutor.
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
- ❌ I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of openedx#35542.
Private-ref: BB-8469 (temporary)