fix: prevent redirects to /undefined after saml auth - #669
Merged
Agrendalath merged 1 commit intoAug 13, 2024
Conversation
When a user authenticates using SAML, but their accounts aren't linked, they land on the login page with the message to link their accounts. If the OC_REDIRECT_ON_TPA_UNLINKED_ACCOUNT value is not setup, they end up getting redirected to /undefined. This commit validates the redirectURL as a valid string before performing the redirect. Internal-ref: https://tasks.opencraft.com/browse/BB-9010
Agrendalath
approved these changes
Aug 13, 2024
Agrendalath
left a comment
Agrendalath
left a comment
Member
There was a problem hiding this comment.
👍
- I tested this: tested that the undefined redirect no longer happens when the variable is not defined
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- Added to the Code Drift project board (for backports)
Agrendalath
deleted the
tecoholic/BB-9010-prevent-redirects-to-undefined-after-saml-auth
branch
August 13, 2024 21:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user authenticates using SAML, but their accounts aren't linked, they land on the login page with the message to link their accounts. If the
OC_REDIRECT_ON_TPA_UNLINKED_ACCOUNT value is not setup, they end up getting redirected to /undefined. This commit validates the redirectURL as a valid string before performing the redirect.
Internal-ref: https://tasks.opencraft.com/browse/BB-9010