feat: Teaching Assistant role [BB-8580] - #632
Merged
Merged
Conversation
0x29a
force-pushed
the
0x29a/bb8580/teaching-assistant
branch
2 times, most recently
from
February 13, 2024 12:11
9f4c91c to
41ebe7f
Compare
0x29a
force-pushed
the
0x29a/bb8580/teaching-assistant
branch
from
February 13, 2024 12:36
41ebe7f to
176de06
Compare
0x29a
commented
Feb 14, 2024
CefBoud
reviewed
Feb 15, 2024
CefBoud
reviewed
Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
Teaching Assistantcourse team role, which is similar to eSHE Instructor, with the only difference being that it doesn't have access to viewing and modifying grades.Provided you set
ENABLE_TEACHING_ASSISTANT_ROLEfeature flag toTrue, as anAdminorStaff, you should see this on theMembershiptab of the instructor dashboard:Screenshot
Here is how the dashboard looks for a user with this role:
Screenshot
You can see that the
Membershiptab is hidden and that theStudent Admintab contains only two sections, unlike the regularStaff, from which the role in question is derived:Screenshot
This role should be composable with any other course team roles. For example,
Teaching Assistant+Adminwill have the same permissions asAdmin.Teaching Assistant+Discussion Adminwill be able to access the membership tab, but assign only forum-related roles.Testing instructions
0x29a/bb8580/teaching-assistantbranch from thegit@github.com:open-craft/edx-platform.gitrepo.ENABLE_TEACHING_ASSISTANT_ROLEtoTrue.course_staff@example.comandta@example.com. Give the formerStaffcourse team role using the Instructor Dashboard.instructor.enroll,instructor.give_student_extension, andinstructor.override_gradespermissions, verify thatcourse_staff@example.comstill can enroll students (Membershiptab) and that all features on theStudent Admintab work for this user as before.ta@example.comtheTeaching Assistantrole.ta@example.com, verify that you have access to the Instructor Dashboard, but not to theMembershiptab.ta@example.comsees only two sections on theStudent Admintab of the dashboard.ta@example.comtheStaffrole and verify that it has allStaffpermissions (can enroll students, see theMembershiptab and allStudent Admincontent).Staffrole fromta@example.com, giveDiscussion Adminand verify that it can assign forum moderator roles.Forum Discussionrole fromta@example.com, giveData Researcherand verify that it can access theData Downloadtab.Additionally, this script can be used to test that the
instructor.enroll,instructor.give_student_extension, andinstructor.override_gradespermissions work as expected: