fix:(palm) limited staff cohorts and gradebook access [BB-7962] - #596
Merged
Conversation
0x29a
force-pushed
the
0x29a/bb7962/fix-limited-staff-access-to-cohorts-and-gradebook-backport
branch
from
October 16, 2023 10:53
dde7efb to
2c19b07
Compare
Limited Staff should not have studio read access by design. However, since many LMS views depend on the `has_course_author_access` check and `course_author_access_required` decorator, we have to allow write access until the permissions become more granular. For example, there should be STUDIO_VIEW_COHORTS and STUDIO_EDIT_COHORTS specifically for the cohorts endpoint, which is used to display "Cohorts" instructor dashboard tab. (cherry picked from commit febcccc)
Agrendalath
force-pushed
the
0x29a/bb7962/fix-limited-staff-access-to-cohorts-and-gradebook-backport
branch
from
October 16, 2023 20:27
2c19b07 to
8e83fa5
Compare
Agrendalath
approved these changes
Oct 16, 2023
Agrendalath
left a comment
Agrendalath
left a comment
Member
There was a problem hiding this comment.
👍
- I tested this: in the upstream PR
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
Agrendalath
deleted the
0x29a/bb7962/fix-limited-staff-access-to-cohorts-and-gradebook-backport
branch
October 16, 2023 21:45
Agrendalath
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of openedx#33491.